Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1272?usp=email )
Change subject: Silence compiler truncation warning by checking snprintf return value ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Hi. Had ignored this for a while mostly because mingw 13.0.0 isn't present in our buildbot fleet, yet. But tested it now and it indeed resolves the issue. But see comments about error handling. File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/1272/comment/8ce84b65_d5cb1a44?usp=email : PS3, Line 3565: M_FATAL I think M_FATAL is too drastic here. A continue would also be okay, like we do for errors on RegOpenKeyEx a few lines below. http://gerrit.openvpn.net/c/openvpn/+/1272/comment/3f5b513f_6359ba5c?usp=email : PS3, Line 3680: msg(M_FATAL, "Error constructing connection string for %s", enum_name); I think M_FATAL is too drastic here. A continue would also be okay, like we do for errors on RegOpenKeyEx a few lines below. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1272?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852 Gerrit-Change-Number: 1272 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 16:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
