Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1293?usp=email )
Change subject: push: Fix conversion issues related to timeout in send_auth_pending_messages ...................................................................... Patch Set 9: (1 comment) File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1293/comment/1ede80cb_484f24b6?usp=email : PS5, Line 451: } > But isn't that correct? In that case "max_timeout" has already expired, so > shouldn't we fail? Since this return value is only what the management interface gets back, it is probably okay to return false here. I don't think we need time_elapsed < 0 here since that now < ks->inital is something that should never happen and checking for it here might be more confusing than good. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1293?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icc31b7fa0da86220df45552aecc15dc6c769cd54 Gerrit-Change-Number: 1293 Gerrit-PatchSet: 9 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 21 Jan 2026 12:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
