Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1494?usp=email
to review the following change.
Change subject: argv: Fix one type to avoid sign-compare warning
......................................................................
argv: Fix one type to avoid sign-compare warning
len is already int, no need to throw another
type into the mix.
Change-Id: Ida8e587a095bdfb821ee0a4783633f026d310476
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/argv.c
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/94/1494/1
diff --git a/src/openvpn/argv.c b/src/openvpn/argv.c
index b5d9603..6a5d92e 100644
--- a/src/openvpn/argv.c
+++ b/src/openvpn/argv.c
@@ -263,11 +263,6 @@
gc_free(&gc);
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wsign-compare"
-#endif
-
/**
* Prepares argv format string for further processing
*
@@ -389,7 +384,7 @@
* Do the actual vsnprintf() operation, which expands the format
* string with the provided arguments.
*/
- size_t size = len + 1;
+ int size = len + 1;
char *buf = gc_malloc(size, false, &argres->gc);
len = vsnprintf(buf, size, f, arglist);
if (len < 0 || len >= size)
@@ -423,10 +418,6 @@
return res;
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
-
/**
* printf() variant which populates a struct argv. It processes the
* format string with the provided arguments. For each space separator found
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1494?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida8e587a095bdfb821ee0a4783633f026d310476
Gerrit-Change-Number: 1494
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
