Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1492?usp=email )
Change subject: cryptoapi: Change signature of parse_hexstring to match code ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I don't like that we are adding a totally unrelated whitespace in a place we are not touching at all (moreover I am not sure why it is being added - it seems clang-format has "opinions"). But other than that the actual change looks good to me and more importantly is adding the "static" attribute which should have been there since the beginning. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1492?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed Gerrit-Change-Number: 1492 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 11:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
