Attention is currently required from: cron2. plaisthos has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1497?usp=email )
Change subject: tunnel_server(): close correct inotify fd ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1497/comment/079de3b1_4b96fdc7?usp=email : PS1, Line 4237: multi.top.c2.inotify_fd = inotify_init(); We set inotify_fd here in (multi->top, which is also CM_TOP_CLONE) instead of top which is CM_TOP. We should probably rename top in this function to something like root_top or something else to avoid the confusion between multi->top and the local top variable. http://gerrit.openvpn.net/c/openvpn/+/1497/comment/de71ce2b_74df9b13?usp=email : PS1, Line 4247: close(top->c2.inotify_fd); and then we close top of the other context. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1497?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iabc117848ad7b67d240c392f1a6aa2d7531fd5bb Gerrit-Change-Number: 1497 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 10:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
