Attention is currently required from: cron2, flichtenheld, plaisthos.
selvanair has posted comments on this change by selvanair. (
http://gerrit.openvpn.net/c/openvpn/+/1528?usp=email )
Change subject: Fixup version command on management interface
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> meh, gerrit tricked me. I answered on the "to respond only if ... […]
I do that all the time -- the other day deleted a dozen old comments that never
saw the light of day...
Anyway, I found "commit 8be444df8" had upped the latest client version to 3, so
enabling this for >= 4. We really need a way to document client versions --
right now one has to just know.
What about something like a private enum in manage.c with {CLIENT_VERSION_BASE
= 1, CLIENT_VERSION_PKSIGN = 2, ... } and then use those like "if
(client_version >= CLIENT_VERSION_PKSIGN)" etc? As a separate patch of course.
Or, is there a better way?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1528?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76dc80a9d9b29e401b7bbd59e0c46baf751d2e4a
Gerrit-Change-Number: 1528
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 24 Feb 2026 20:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
