Attention is currently required from: flichtenheld, plaisthos.

plaisthos has posted comments on this change by selvanair. ( 
http://gerrit.openvpn.net/c/openvpn/+/1548?usp=email )

Change subject: Add an optional username-only flag for auth-user-pass
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS4:
The patch overall looks good but think the usability how to use the feature 
needs to be clearer.


File doc/man-sections/client-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1548/comment/695f9498_3d55bfa1?usp=email :
PS4, Line 96:
So I have a bit of usability problems here. If I want to put the username to 
use into the profile, in typical OpenVPN fashion I expect to having to use

auth-user-pass username-only
<auth-user-pass>
theusername
</auth-user-pass>

which is not necessarily obvious. If we want this to be the way, we should at 
least document it.

And something like

auth-user-pass /some/file username-only does not seem to be supported.

auth-user-pass username-only
auth-user-pass /some/file username-only

might work but is not intuitive either.

Maybe have something like auth-sendusername as alias to auth-user-pass that 
imlicitlty sets the flag and otherwise works the same as auth-user-pass?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1548?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I788f76e6a70a9c20bca3367140d2741bd0551582
Gerrit-Change-Number: 1548
Gerrit-PatchSet: 4
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 02 Mar 2026 15:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to