From: Frank Lichtenheld <[email protected]> It returns int, so use that. Avoids a sign-compare warning.
Change-Id: Ie8135a31b1f8f70ce0ddf63d7653f3d84a9e983f Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Arne Schwabe <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1493 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1493 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe <[email protected]> Gert Doering <[email protected]> diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index c61e4b2..d8c4587 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1491,17 +1491,11 @@ return len; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - /* sign arbitrary data */ static int rsa_priv_enc(int flen, const unsigned char *from, unsigned char *to, RSA *rsa, int padding) { - unsigned int len = RSA_size(rsa); - int ret = -1; + int len = RSA_size(rsa); if (padding != RSA_PKCS1_PADDING && padding != RSA_NO_PADDING) { @@ -1509,15 +1503,11 @@ return -1; } - ret = get_sig_from_man(from, flen, to, len, get_rsa_padding_name(padding)); + int ret = get_sig_from_man(from, flen, to, len, get_rsa_padding_name(padding)); return (ret == len) ? ret : -1; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - static int tls_ctx_use_external_rsa_key(struct tls_root_ctx *ctx, EVP_PKEY *pkey) { _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
