Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email )
Change subject: wfp: add flag to allow DNS traffic to loopback ...................................................................... Patch Set 2: (2 comments) File doc/man-sections/windows-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1541/comment/02f29f5c_ebfbd6bf?usp=email : PS1, Line 23: Windows XP) to ignore said error. Note that pushing unknown options from > Can we maybe remove this Windows XP mention as a drive-by fix? Hm, I find the whole paragraph of limited use and would remove it rather completely. On the other hand it's not directly related to the change here. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1541/comment/b298a86e_de1d4f16?usp=email : PS1, Line 855: if (msg->block_type >= 0 && msg->block_type < wfp_block_type_count) > I don't understand this conditional. […] It's exactly the wrong way around. Good catch. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0f7237720b0892f5ba0caf60f941f9cc2241cdb6 Gerrit-Change-Number: 1541 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 01:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
