cron2 has uploaded a new patch set (#6) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1502?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: push: Improve check of vsnprintf return value ...................................................................... push: Improve check of vsnprintf return value Avoid sign-compare warning and do not ignore error return values. Change-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Arne Schwabe <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1502 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg35905.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/push.c 1 file changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1502/6 diff --git a/src/openvpn/push.c b/src/openvpn/push.c index 8541467..93c5558 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -800,11 +800,6 @@ gc_free(&gc); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - bool send_push_reply(struct context *c, struct push_list *per_client_push_list) { @@ -936,7 +931,7 @@ va_start(arglist, format); len = vsnprintf(tmp, sizeof(tmp), format, arglist); va_end(arglist); - if (len > sizeof(tmp) - 1) + if (len < 0 || len >= (int)sizeof(tmp)) { return false; } @@ -944,10 +939,6 @@ return true; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - void push_reset(struct options *o) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1502?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574 Gerrit-Change-Number: 1502 Gerrit-PatchSet: 6 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
