Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1508?usp=email )
Change subject: crypto: Change cipher_kt_*_size to return size_t instead of int ...................................................................... Patch Set 6: Code-Review-1 (3 comments) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/1508/comment/8b0e13d7_3c7a3f09?usp=email : PS6, Line 91: const unsigned int iv_len = cipher_ctx_iv_length(ctx->cipher); Shouldn't this trigger a warning because we are putting a 8 byte int into a 4 byte int File src/openvpn/crypto_backend.h: http://gerrit.openvpn.net/c/openvpn/+/1508/comment/c62f107f_bb65928c?usp=email : PS6, Line 284: size_t cipher_kt_tag_size(const char *ciphername); I would like to have some more consistency here. We are making cipher_ctx_iv_length an unsigned int but this a size_t http://gerrit.openvpn.net/c/openvpn/+/1508/comment/4d9f4906_47ca6c0c?usp=email : PS6, Line 379: unsigned int cipher_ctx_block_size(const cipher_ctx_t *ctx); This is an unsigned int while the non context uses a different return type of size_t -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1508?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9 Gerrit-Change-Number: 1508 Gerrit-PatchSet: 6 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 10:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
