Thanks for coming up with a minimal patch quickly, until we have decided
what "we really want there" and "what windows does".

Frank has tested this, and I have fixed my testbed to actually *show* the
problem - we do windows tests, but the way I had set up the "hidden DNS
things that only resolve if --dns is applied correctly" (unbound with a
local zone) was IPSEC-agnostic - if you ask "the authoritative server"
it will always tell you "yeah, all is valid!".  So now we have an unbound
recursor in front of a local bind, with no DNSSEC, and "windows with
dnssec yes" will actually fail to resolve that...  

.. and with your patch, we're back to "the system tests pass", so, good.

(Staring at the change also seems to make sense, but I said so for
the other fix as well... so I'm glad we have good before/after tests
this time)

Your patch has been applied to the master and release/2.7 branch.

commit 919f5ced7d2863d51981979a336407b6e0818fcd (master)
commit 9683e1fe273db94ab92e1da2fe55c7929fa7291a (release/2.7)
Author: Selva Nair
Date:   Thu Apr 30 14:40:14 2026 +0200

     dns: minimalist fix for dnssec setting

     Signed-off-by: Selva Nair <[email protected]>
     Acked-by: Frank Lichtenheld <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg36797.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to