Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email )

Change subject: Change hash iv to a dynamically allocated ctx
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

File src/openvpn/list.h:

http://gerrit.openvpn.net/c/openvpn/+/1571/comment/93d3f73b_2fadf384?usp=email :
PS5, Line 106: void *hash_func_new_ctx(void);
please provide documentation for new functions


File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1571/comment/9a502f44_82e37234?usp=email :
PS5, Line 313:         hash_init(t->options.real_hash_size, NULL, free, 
int_hash_function, int_compare_function);
why NULL here and not hash_func_new_ctx ?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If47c7d920b2fa4047b7db03fcde821899839324d
Gerrit-Change-Number: 1571
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 15:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to