Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email

to review the following change.


Change subject: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
......................................................................

t_client.sh.in: Do not try to guess the absolute path to LOGDIR

We know it, we do not need to guess it. Makes it easier
to move LOGDIR around.

Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M tests/t_client.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/1764/1

diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in
index 78c8bca..1234215 100755
--- a/tests/t_client.sh.in
+++ b/tests/t_client.sh.in
@@ -126,6 +126,7 @@
 fi

 LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S`
+LOGDIR_ABS="$PWD/$LOGDIR"
 if mkdir $LOGDIR
 then :
 else
@@ -383,7 +384,7 @@
        printf "$outbuf" ; continue
     fi

-    pidfile="${top_builddir}/tests/$LOGDIR/openvpn-$SUF.pid"
+    pidfile="$LOGDIR_ABS/openvpn-$SUF.pid"
     openvpn_conf="$openvpn_conf --writepid $pidfile $up"
     output " run openvpn $openvpn_conf"
     echo "# ${openvpn} $openvpn_conf" >$LOGDIR/$SUF:openvpn.log

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Gerrit-Change-Number: 1764
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to