Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1765?usp=email

to review the following change.


Change subject: ssl_pkt: Fix doxygen warning about read_control_auth
......................................................................

ssl_pkt: Fix doxygen warning about read_control_auth

Commit 01ee1693f960a696a613e7b83f9960002264a379
("Ensure tls-crypt keys are not setup twice") removed
the argument but did not delete it from the doxygen
documentation, leading to warnings.

Change-Id: I20cc89a546b69aceadcd1630828de407d530d7c7
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/ssl_pkt.h
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/1765/1

diff --git a/src/openvpn/ssl_pkt.h b/src/openvpn/ssl_pkt.h
index 640885e..82cb5b1 100644
--- a/src/openvpn/ssl_pkt.h
+++ b/src/openvpn/ssl_pkt.h
@@ -207,7 +207,6 @@
  * @param ctx               control channel security context
  * @param from              incoming link socket address
  * @param opt               tls options struct for the session
- * @param initial_packet    whether this is the initial packet for the 
connection
  * @return                  if the packet was successfully processed
  */
 bool read_control_auth(struct buffer *buf, struct tls_wrap_ctx *ctx,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1765?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I20cc89a546b69aceadcd1630828de407d530d7c7
Gerrit-Change-Number: 1765
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to