Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email )
Change subject: oob: Add control message TLV encoding (P_CONTROL_OOB_V1) ...................................................................... Patch Set 4: (5 comments) File src/openvpn/oob.h: http://gerrit.openvpn.net/c/openvpn/+/1741/comment/615dc762_016d178a?usp=email : PS3, Line 35: * This slice implements the SERVER_PROBE / PROBE_REPLY pair used for server > Not sure of the purpose of this sentence? This is about series of patches. I agree it might add confusion so I'll remote it. http://gerrit.openvpn.net/c/openvpn/+/1741/comment/298aabee_731ed6bc?usp=email : PS3, Line 62: #define OOB_PROBE_PARAMETER_LEN 12 > why do we hardcode those instead of defining them via sizeof() ? Those are on-wire lengths, so sizeof(struct) could be wrong due to padding. But let me derive from wire field types instead. File src/openvpn/oob.c: http://gerrit.openvpn.net/c/openvpn/+/1741/comment/c951b8b7_d2f6c9a8?usp=email : PS3, Line 31: /* Consume @p value_len bytes of TLV value, of which @p consumed have already > Doxygen syntax but not marked as Doxygen comment Will change to real doxygen. http://gerrit.openvpn.net/c/openvpn/+/1741/comment/01cc794e_e144d4ad?usp=email : PS3, Line 105: if (!ok) > Is that safe? If the buffer has enough to read for u32 but not for u64 could > we end up with ok being […] No, this is a bug. Will fix. File tests/unit_tests/openvpn/test_oob.c: http://gerrit.openvpn.net/c/openvpn/+/1741/comment/5475378e_0edbd3c9?usp=email : PS3, Line 153: /* Reading a header from a buffer that is too small must fail rather than read > This comment does not seem to correspond to the test. The buffer is big > enough. […] Will rephrase, thanks! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c8d302ac57c5603d622a7be14be369437388268 Gerrit-Change-Number: 1741 Gerrit-PatchSet: 4 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 13:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
