Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1725?usp=email )
Change subject: Extract multi_get_instance_real_udp_real method ...................................................................... Patch Set 3: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1725/comment/d3c8bcaa_da0242e4?usp=email : PS2, Line 298: const uint64_t hv = hash_value(hash, &real); > Yes, why do we recompute that in multi_get_instance_udp_real and > handle_connection_attempt? Because the one in handle_connection_attempt will be removed/replaced by the per SID hash lookup with the follow up patch and this felt like the cleaner approach for the code -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1725?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37ade55d7674c68dd98cf4dfde35c4ad42e20d39 Gerrit-Change-Number: 1725 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 14 Jul 2026 12:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
