Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email )
Change subject: Split multi_get_create_instance_udp into data and control parts ...................................................................... Patch Set 4: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1726/comment/8b863414_2e4c433f?usp=email : PS4, Line 364: if (!mroute_extract_openvpn_sockaddr(&real, &m->top.c2.from.dest, true) || m->top.c2.buf.len == 0) > This check is too late now and it is wrong. In t_server testbed we see > segfaults: […] Yes I overlooked that || m->top.c2.buf.len == 0) part during refactor being critical. I moved it to a more explicit and logical place. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8e9923b51b77f184c7d49d697004cb02d2b5cfc3 Gerrit-Change-Number: 1726 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 12:17:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
