Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1790?usp=email )
Change subject: pool, multi: persist subnet pools via --ifconfig-pool-persist ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File tests/unit_tests/openvpn/test_pool.c: http://gerrit.openvpn.net/c/openvpn/+/1790/comment/1147dfba_d7ec3fa8?usp=email : PS1, Line 226: int fd = mkstemp(template); ``` C:\Buildbot\windows-server-2025-latent-ec2-msbuild-amd64\build\tests\unit_tests\openvpn\test_pool.c(226,14): error C2220: the following warning is treated as an error [C:\Buildbot\windows-server-2025-latent-ec2-msbuild-amd64\build\out\build\win-amd64-release\test_pool.vcxproj] C:\Buildbot\windows-server-2025-latent-ec2-msbuild-amd64\build\tests\unit_tests\openvpn\test_pool.c(226,14): warning C4013: 'mkstemp' undefined; assuming extern returning int [C:\Buildbot\windows-server-2025-latent-ec2-msbuild-amd64\build\out\build\win-amd64-release\test_pool.vcxproj] ``` Maybe use platform_create_temp_file like test_ssl? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1790?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0bff8d0a549a65b7da01ea0e785b7ec8bea17f05 Gerrit-Change-Number: 1790 Gerrit-PatchSet: 1 Gerrit-Owner: ordex <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 10:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
