Attention is currently required from: cron2, flichtenheld, plaisthos. its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )
Change subject: multipeer: introduce asymmetric peer-id ...................................................................... Patch Set 19: (6 comments) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/60ec1c4c_82ec962f?usp=email : PS18, Line 693: dco_win_add_iroute_ipv6(&c->c1.tuntap->dco, addr->v6.addr, addr->netbits, c->c2.tls_multi->rx_peer_id); > is this unwrapping intentional? Unintentional File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/e495bd2c_9f3ac369?usp=email : PS18, Line 2695: c->c2.tls_multi->tx_peer_id = c->options.peer_id; > why set `tx_peer_id` twice, to the same value? Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/d9f5177e_03242945?usp=email : PS18, Line 3144: print_link_socket_actual(&m->top.c2.from, &gc)); > this change looks like a rebase artefact - the `rx_peer_id` is clear, but the > `mroute_addr_print` pa […] Done File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/8eaa710e_d2d3ae5e?usp=email : PS18, Line 667: tls_multi->rx_peer_id); > was this wrapping intentional? it makes reading the diff harder... Uintentional. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/c63de6c1_f1737fb4?usp=email : PS18, Line 2079: : write_empty_string(buf))) > please do not call functions with side effects as part of a ternary condition > in an if() - it's real […] Done File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/40aeeff6_de002fe1?usp=email : PS18, Line 457: multi->tx_peer_id = 0x76706e; /* 'v' 'p' 'n' */ > setting the magic number for p2p peer-id should be done once. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9 Gerrit-Change-Number: 1089 Gerrit-PatchSet: 19 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2026 12:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
