Thanks for this work.
Nagle was a good idea to better fill TCP packets for "piecemeal senders"
using many small write() calls, but I don't think it ever made sense to
not have TCP_NODELAY for OpenVPN - so the initial approach to "just rip
it out" made lots of sense. Except, of course, for compat with existing
setups - so we keep the "push" behaviour for servers with "tcp-nodelay"
in their config, and old clients that might need it...
I have not tested it "in earnest", but since it's not actually *adding*
code, just taking away variants, "seeing positive results from the BBs"
is good enough (and I'm fairly sure some of the repeated spurious TCP
failures in the BB t_client tests can be attributed to not having
TCP_NODELAY set).
Since the patch is simple, and the outcome highly desirable, we consider
it acceptable for "in the middle of the 2.7 series".
Your patch has been applied to the master and release/2.7 branch.
commit da4ecf990b55d6c19cdc3e01c19b989de26fc88e (master)
commit 21f662e88266c71353f08c05f91b32b0d138397f (release/2.7)
Author: Antonio Quartulli
Date: Tue Jul 21 14:44:46 2026 +0200
Enable TCP_NODELAY by default and push it to clients
Signed-off-by: Antonio Quartulli <[email protected]>
Acked-by: Arne Schwabe <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1797
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg37726.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
