Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1830?usp=email )
Change subject: SIGHUP-restart instance on UDP write error EADDRNOTAVAIL ...................................................................... Patch Set 2: (4 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/1830/comment/572a9546_aa6773b9?usp=email : PS2, Line 1865: if (size < 0 && errno == EADDRNOTAVAIL) > good catch. Will adjust. […] well, unless EADDRNOTAVAIL on Windows is equal to some WSRANDOMTHING that may be returned under other circumstances, no (hopefully not)? http://gerrit.openvpn.net/c/openvpn/+/1830/comment/c7127dda_9938ba98?usp=email : PS2, Line 1868: register_signal(c->sig, SIGHUP, "link-changed"); > I can't follow you. […] you're right. I was testing with `--config stdin` and the other option was already there in my harness, but it's indeed irrelevant. At the same time I searched this pattern across the code and I saw other spots where we register SIGHUP without checking if config is coming from stdin. So this patch has indeed this issue, but it's not new :-D !!! You can decide if you want to add a guard here or if this should be fixed later on along the other spots. Moreover, the other spots where we register SIGHUP have a `c->persist.restart_sleep_seconds = 10;` right after, so that we do not busy loop in case of permanent error. Worth adding here too? http://gerrit.openvpn.net/c/openvpn/+/1830/comment/8a5b06fd_81757e6d?usp=email : PS2, Line 1868: register_signal(c->sig, SIGHUP, "link-changed"); > In this case, we would do a `SIGHUP` reconnect anyway, just "after > `--ping-restart` expires". […] When we hit `connect_retry_max` attempts, we have an M_FATAL that stops everything. With this patch we'll keep looping. Note, as I said in the other comment, there are other areas of the code where we register SIGHUP and also in those cases we don't honor `connect-max-reply`... http://gerrit.openvpn.net/c/openvpn/+/1830/comment/1f257674_6a405be6?usp=email : PS2, Line 1868: register_signal(c->sig, SIGHUP, "link-changed"); > I'm not sure this can be triggered in a meaningful way on a server - there > are no redirect routes fo […] Agreed this might be difficult, but there might be other scenarios (which we are not seeing now) that may trigger this error. Thanks! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1830?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I96b5ea3542df77b1be17079874fb9e4970b539ed Gerrit-Change-Number: 1830 Gerrit-PatchSet: 2 Gerrit-Owner: cron2 <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 13:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
