Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email )
Change subject: Make required action returned from pre_decrypt_verdict more explicit ...................................................................... Patch Set 6: (3 comments) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1826/comment/0e5c043b_23a1402b?usp=email : PS6, Line 219: return PRE_DECRYPT_CREATE_SESSION_SKIP; > If I got this right, before we returned FALSE for invalid/missing SID or > wrong pid, and the calling […] Done http://gerrit.openvpn.net/c/openvpn/+/1826/comment/88ece37c_ae307f74?usp=email : PS6, Line 249: return NULL; > here we leak gc Done http://gerrit.openvpn.net/c/openvpn/+/1826/comment/0994f11a_6c2811e3?usp=email : PS6, Line 280: mi->context.c2.tls_multi->n_sessions++; > previously we only incremented sessions when we skipped to pre_start and now > we do it for CREATE_SES […] No. That would count it double. Moved to the if clause below. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iccdd4cfad090c565aac27e16cdaa9871106c2f89 Gerrit-Change-Number: 1826 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 11:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
