Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email )

Change subject: options: Factor out options_string code from options.c
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/options_string.h:

http://gerrit.openvpn.net/c/openvpn/+/1773/comment/dca28b61_5f2f174d?usp=email :
PS2, Line 24: #define OPTIONS_SHOW_H
> This looks wrong. […]
Thanks for catching that. It didn't cause any compiler errors since 
options_show.h is only included in openvpn.c which doesn't include 
options_string.h



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6824058fc9c4efd48ceeb32d4164f97b2a243d85
Gerrit-Change-Number: 1773
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 10:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to