Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1585?usp=email )
Change subject: dev-tools: Add new script to convert mails to Gerrit patches ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: In addition to the inline comments, this script only deals with `HEAD` as far as I can tell (so it ignores an mbox series). If that's intended, that's fine. File dev-tools/gerrit-submit-from-mail.sh: http://gerrit.openvpn.net/c/openvpn/+/1585/comment/ceda5c85_2f73518c?usp=email : PS1, Line 18: TIMESTAMP=$(date +%Y%M%dT%H%S) This timestamp looks broken. `M` is minutes. I believe you want `%Y%m%dT%H%M%S`. http://gerrit.openvpn.net/c/openvpn/+/1585/comment/2e0a21c6_19bd43c0?usp=email : PS1, Line 22: git -C $SOURCE_DIR am Should we check if this failed? http://gerrit.openvpn.net/c/openvpn/+/1585/comment/69690139_ec9cd096?usp=email : PS1, Line 37: if [ "$warnings" -ge 0 ]; then Isn't `warning` always `>= 0`? Did you mean `-gt` here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1585?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I52773764e0f4056fe5367918a9b2e6720b165c21 Gerrit-Change-Number: 1585 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 06:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
