Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1755?usp=email )
Change subject: t_client.sh.in: Add support for expected test failures ...................................................................... Patch Set 5: (3 comments) File tests/t_client.sh.in: http://gerrit.openvpn.net/c/openvpn/+/1755/comment/ec2bfe4b_d246d881?usp=email : PS5, Line 379: $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log & Should we make sure we don't also include these two synthetic lines in the grep input to prevent false positives? http://gerrit.openvpn.net/c/openvpn/+/1755/comment/9f820460_22e83dd1?usp=email : PS5, Line 389: grep "$expect_fail" $LOGDIR/$SUF:openvpn.log >/dev/null If we're not allowing for regular expressions, do we want this to be `grep -F`? http://gerrit.openvpn.net/c/openvpn/+/1755/comment/e37a40a4_bab6d266?usp=email : PS5, Line 434: continue This `else` branch does not kill the OpenVPN process like the branch above does (i.e. `$RUN_SUDO $KILL_EXEC $sudopid`). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1755?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c51bcdda5666e0dab2adcdaff28408c9bfcb844 Gerrit-Change-Number: 1755 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 07:23:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
