Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1663?usp=email )

Change subject: Remove instances of constParameterPointer cppcheck warnings
......................................................................


Patch Set 24:

(3 comments)

File dev-tools/cppcheck-suppression:

http://gerrit.openvpn.net/c/openvpn/+/1663/comment/0be163f5_bbac1f68?usp=email :
PS23, Line 74: # FP: const silently removed due to pointer arithmentic
> Typo: "arithmetic".
Done


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/1663/comment/958ab3b1_1acbb739?usp=email :
PS17, Line 3253: read_tun(struct tuntap *tt, uint8_t *buf, int len)
> Shouldn't this (and the function above) have been constified as well? Do we 
> no longer build for AIX? […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1663/comment/5c457639_19297594?usp=email :
PS17, Line 6310: read_tun(struct tuntap *tt, uint8_t *buf, int len)
> Here too, this function and the one above have not been constified.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1663?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I56248cf6d199c2da770774b8fd1e5daf2b116f58
Gerrit-Change-Number: 1663
Gerrit-PatchSet: 24
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Fri, 11 Sep 2026 15:09:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to