I just updated the PR. I have removed the button and hooked the normal mode event to the new button. Thanks for the idea about broken windows by the way.
On Monday, 27 March 2017 20:20:10 UTC+1, Federico Capoano wrote: > > Could you hook the event to the new "exit advanced mode" button? > > That way we would avoid having redundant code sitting around and risking > of being forgotten. Removing it will make the job of future maintainers > easier. > > Have you ever heard of "the broken windows theory"? > > If not, look it up, it's an interesting concept. > > Consider redundant code like a broken window. > > Federico > > Il lun 27 mar 2017, 21:11 GASTON CHE <[email protected] <javascript:>> ha > scritto: > >> I have just updated the PR with the changes as required. But I have not >> removed the hidden normal mode button. The button is still useful because >> the events to exit advanced mode is hooked only to it. >> >> >> On Monday, 27 March 2017 20:04:26 UTC+1, GASTON CHE wrote: >>> >>> editor fixes for issue #45 >>> <https://github.com/openwisp/django-netjsonconfig/issues/45>. handled >>> all the required fixes as specified. @nemesisdesign >>> <https://github.com/nemesisdesign>. >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "OpenWISP" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
