Hi Everyone,

We recently completed the first phase of work to ensure deactivated devices
behave consistently in OpenWISP.

The controller now has generic enforcement for deactivated devices, so
device configuration, provisioning, and related controller operations can
stop acting on devices that have been intentionally decommissioned.

While reviewing that work, we also audited other OpenWISP modules
using the OpenWISP
Device Operation Analysis
<https://docs.google.com/spreadsheets/d/1teJ3SatCszbAAF8qYc0tphV293xeI0I8ny6Y8sMs7Z8/edit?gid=294839753#gid=294839753>
spreadsheet.

The goal was to identify operations that may still act on deactivated
devices, or on disabled organizations (whose is_active flag is set to False
).

This is needed because several OpenWISP modules perform work outside the
normal admin or REST API request flow.

Examples include Celery tasks, scheduled jobs, signal handlers, key-auth
ingestion endpoints, monitoring workflows, firmware upgrade jobs, RADIUS
accounting, notifications, and topology/device integration logic. These
paths can bypass UI-level filtering unless explicit checks are added in the
model, task, or service layer.

The intended policy is:

   - disabled organizations should remain readable and deletable where
   appropriate;
   - disabled organizations should not receive new writes or automated
   processing;
   - deactivated devices should not be selected for new operational work;
   - cleanup and status synchronization should continue when needed to keep
   data consistent.

*I wanted to inform you about this because we found out OpenWISP modules do
not always behave consistently in regards to these two aspects (deactivated
devices and disabled organizations) but we're working to fix this.*

Recent completed work:

   - openwisp/openwisp-controller#1365: [change] Added generic enforcement
   of deactivated devices #1338
   <https://github.com/openwisp/openwisp-controller/pull/1365>

The open issues below track the remaining work across repositories:

   -

   openwisp/openwisp-controller#1393: [change] Limit controller operations
   on disabled organizations
   <https://github.com/openwisp/openwisp-controller/issues/1393>
   -

   openwisp/openwisp-users#522: [change] Make disabled organizations
   readonly but deletable
   <https://github.com/openwisp/openwisp-users/issues/522>
   -

   openwisp/openwisp-notifications#472: [change] Do not generate
   notifications for disabled organizations
   <https://github.com/openwisp/openwisp-notifications/issues/472>
   -

   openwisp/openwisp-firmware-upgrader#382: [bug] Upgrade operations should
   not include deactivated devices
   <https://github.com/openwisp/openwisp-firmware-upgrader/issues/382>
   -

   openwisp/openwisp-firmware-upgrader#445: [change] Enforce
   disabled-organization rules in firmware upgrades
   <https://github.com/openwisp/openwisp-firmware-upgrader/issues/445>
   -

   openwisp/openwisp-monitoring#811: [change] Prevent monitoring operations
   on deactivated devices
   <https://github.com/openwisp/openwisp-monitoring/issues/811>
   -

   openwisp/openwisp-monitoring#812: [change] Enforce disabled-organization
   rules in monitoring
   <https://github.com/openwisp/openwisp-monitoring/issues/812>
   -

   openwisp/openwisp-radius#729: [change] Enforce disabled-organization
   rules in RADIUS <https://github.com/openwisp/openwisp-radius/issues/729>
   -

   openwisp/openwisp-network-topology#302: [change] Respect disabled
   organizations and deactivated devices in topology operations
   <https://github.com/openwisp/openwisp-network-topology/issues/302>


Best regards
*Federico Capoano*
OpenWISP OÜ
Kotkapoja tn 2a-10, 10615, Harju maakond, Tallinn, Estonia
VAT: EE101989729
+372 59361689
*openwisp.io* <http://openwisp.io>

-- 
You received this message because you are subscribed to the Google Groups 
"OpenWISP" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion, visit 
https://groups.google.com/d/msgid/openwisp/CAAGgX6LDeG%2BhVhq0p-%2BOsUcMMkzWtvXx4h6YwMVn1LnrvE0qng%40mail.gmail.com.

Reply via email to