On Tue, March 2, 2010 07:10, Imre Kaloz wrote: > On 2010.03.02. 04:52:23 Nico <n...@openwrt.org> wrote: > >> Well, using DEVICE_TYPE does not solve the issue, it will just prevent >> netfilter modules from being embedded in the final images, but wont >> prevent them from being built and that will just fail for those targets >> that have CONFIG_NETFILTER not set. >> >> There are 2 options now if we don't want a FIREWALL "feature" : >> >> 1) set CONFIG_NETFILTER=y in all targets, even for those that don't >> need/use it ; >> >> 2) move CONFIG_NETFILTER=y out of kernel configs and add it to KCONFIG >> in kmod-ipt-core, which will have almost the same effect as (1) but >> Netfilter will only be enabled in target kernels if kmod-ipt-core is >> selected. >> >> The current way of solving those issues right now have been a bunch of >> DEPENDS:=@(!(TARGET_ps3||TARGET_pxcab)||BROKEN) where appropriate. We >> need to find a Better Way To Do It (tm) here (the same apply to >> CONFIG_WIRELESS btw). >> >> Feedback welcome (and mandatory) ;) > > What about one part "2" plus extending the device_type part (use it as a > dependency)? "1" doesn't make sense, neither alone "2" really.. > > > Imre
What about "2" plus "# CONFIG_NETFILTER is not set" in general kernel configs? Is that possible and reasonable, or is that not a difference in all? (Yes, I still have to learn a bunch about OpenWrt's build system) Maddes _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
