Hi,
Sorry I do not understand the meaning of "eol". I think you mean to say
no further development is going on with 8.09.
I can create patch against trunk. I do not know but if linux code is
getting changed continuously in trunk then I am afraid we need to apply
this patch manually. Is it okay ?
"Also, it would have been nice to mention the source for this patch and
keep the copyright notice intact." -- Do you mean to say that next time
when I submit this patch I should mention the code version against which
I prepare the patch ?
I have introduced copyright in one file only, sflash.c. Please let me
know what would be the Copyright content. I will put that into that file.
Thank you for showing interest in my kernel patch. I would definitely
try to find out the corresponding wired driver.
Thanks & Regards,
Tathagata
Bernhard Loos wrote:
2010/4/29 Tathagata Das <tathag...@alumnux.com>:
Hi,
This is my first kernel patch submission. Please let me know if I do any
mistake.
All changes are made either under CONFIG_WNR3500L tag or "Tatha" tag.
Regards,
Tathagata <tathag...@alumnux.com>
Hello
Thanks for the patch, but there are a number of problems with it:
Firstly, 8.09 is eol, so if you submit patches, do it agains trunk.
Then, this #ifdef mess is really ugly. It's ok to create a config
symbol for the wnr3500l support, but the number of #ifdefs should be
kept to the absolutely needed minimum and it should be possible to
build a kernel which supports both the older broadcom socs and the new
one.
Also, it would have been nice to mention the source for this patch and
keep the copyright notice intact.
There is already work underway to add basic platform support for this
soc into openwrt, it would be really helpful, if you could find the
wired network driver and get it up and running.
Bernhard
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
