Hey Alan, I don't think this is an good idea - not because of this particular change but that kind changes in general.
I'd like to keep our repository _as close as possible_ to the official openwrt backfire branch upstream. Your patch is a cosmetic change - nothing critical, nothing which changes actual functionality. >From my point of view - and yes, I'm not just willing, I _like_ to discuss that - there's no need to diverge from upstream with that kind of changes. So - still just from my point of view - there are two ways how to handle these kind of changes: 1) Get it upstream, e.g. sending it to the openwrt-devel mailing list or creating a ticket (http://dev.openwrt.org/) and mark it as feature request 2) Just do not commit that kind of changes Discussion is open :) Cheers mirko On Fri, 2010-10-08 at 22:45 -0600, Alan Post wrote: > My name is Alan Post. I'm a developer for the NanoNote, which uses > OpenWrt. > > I've ported a package that does not need any patches, so I excluded > the patches directory. This resulted in an error from ls during > make: > > ls: cannot access ./patches: No such file or directory > > Here is the url to my commit at qi-hardware: > > > http://projects.qi-hardware.com/index.php/p/openwrt-xburst/source/commit/d340b5b5332e0c07b53c46040a11b28fc982bafc/ > > And here is the patch inlined: > > <++> nopatches.diff > diff --git a/include/quilt.mk b/include/quilt.mk > index 598c6f8..6c4839b 100644 > --- a/include/quilt.mk > +++ b/include/quilt.mk > @@ -39,7 +39,7 @@ define PatchDir/Quilt > endef > > define PatchDir/Default > - @if [ -d "$(2)" -a "$$$$(ls $(2) 2>/dev/null | wc -l)" -gt 0 ]; then \ > + @if [ -d "$(2)" -a "$$$$(ls $(2) | wc -l)" -gt 0 ]; then \ > if [ -s "$(2)/series" ]; then \ > $(call filter_series,$(2)/series) | xargs -n1 \ > $(PATCH) "$(1)" "$(2)"; \ > <--> > > -Alan -- This email address is used for mailinglist purposes only. Non-mailinglist emails will be dropped automatically. If you want to get in contact with me personally, please mail to: mirko.vogt <at> nanl <dot> de _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
