2011/8/29 <edgar.sol...@web.de>

> On 29.08.2011 17:14, Jonas Gorski wrote:
> > On 29 August 2011 17:04,  <edgar.sol...@web.de> wrote:
> >> On 29.08.2011 16:44, Jan Willies wrote:
> >>> 2011/8/29 <edgar.sol...@web.de <mailto:edgar.sol...@web.de>>
> >>>
> >>>     On 29.08.2011 16 <tel:29.08.2011%2016>:14, Jan Willies wrote:
> >>>     > Hi Luka,
> >>>     >
> >>>     > 2011/8/21 Luka Perkov <open...@lukaperkov.net <mailto:
> open...@lukaperkov.net> <mailto:open...@lukaperkov.net <mailto:
> open...@lukaperkov.net>>>
> >>>     >
> >>>     >      define Package/openvpn
> >>>     >       SECTION:=net
> >>>     >       CATEGORY:=Network
> >>>     >     +  SUBMENU:=VPN
> >>>     >       DEPENDS:=+kmod-tun +libopenssl
> +PACKAGE_openvpn_complzo:liblzo
> >>>     >
> >>>     >
> >>>     > The lzo dependency doesn't seem to work. It's not selected here.
> >>>
> >>>     as openvpn_complzo obviously is a package definition why isn't the
> liblzo dependency defined there? that would definitely select it then.
> >>>
> >>>
> >>> It's just a configuration option (Config.in), not a full featured
> package. Depending on it there makes it unavailable in menuconfig unless lzo
> is selected. This is not desired IMO.
> >>>
> >>>
> >>
> >> i see, but there is only a OPENVPN_LZO there in Config.in . So wouldn't
> it be
> >>
> >> +OPENVPN_LZO:liblzo
> >
> > OPENVPN_LZO /disables/ lzo, so it should be:
> >
> > +!OPENVPN_LZO:liblzo
> >
> >
> > which incidentially shows that the option names are misleading and
> > they should be renamed or their effect reversed, so that they enable,
> > not disable (I'd prefer the latter).
> >
> >
>
> right missed that. and yes reversing would be most elegant. ede
>

fixed in r28120
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to