Hello,

when you select kmod-pcspkr in menuconfig, it wants to confirm SND_PCSP during the compilation (make V=99). While compiling with no verbosity, compilation fails (only for x86 target).

There are more ways how to solve this issue, but I had some difficulties with propagating variables from generic x86 target and I wanted to leave x86 target untouched and make it as clean as it is now.

This patch creates new package kmod-snd-pcsp which replaces broken kmod-pcspkr for x86 target. kmod-pcspkr for other targets still remains.

Regards,
Jiri Slachta, CESNET, z.s.p.o.
Signed-off-by: Jiri Slachta <slac...@cesnet.cz>
Index: package/kernel/modules/sound.mk
===================================================================
--- package/kernel/modules/sound.mk     (revision 33595)
+++ package/kernel/modules/sound.mk     (working copy)
@@ -9,6 +9,7 @@

 define KernelPackage/pcspkr
   SUBMENU:=$(SOUND_MENU)
+  DEPENDS:=@!TARGET_x86
   TITLE:=PC speaker support
   KCONFIG:=CONFIG_INPUT_PCSPKR
   FILES:=$(LINUX_DIR)/drivers/input/misc/pcspkr.ko
@@ -125,6 +126,26 @@
 $(eval $(call KernelPackage,sound-seq))


+define KernelPackage/sound-pcsp
+  TITLE:=PC speaker support
+  DEPENDS:=@TARGET_x86
+  KCONFIG:= \
+       CONFIG_INPUT_PCSPKR \
+       CONFIG_SND_PCSP
+  FILES:= \
+       $(LINUX_DIR)/drivers/input/misc/pcspkr.ko \
+       $(LINUX_DIR)/sound/drivers/pcsp/snd-pcsp.ko
+  AUTOLOAD:=$(call AutoLoad,50,pcspkr snd-pcsp)
+  $(call AddDepends/sound)
+endef
+
+define KernelPackage/sound-pcsp/description
+ This enables sounds (tones) through the pc speaker
+endef
+
+$(eval $(call KernelPackage,sound-pcsp))
+
+
 define KernelPackage/sound-i8x0
   TITLE:=Intel/SiS/nVidia/AMD/ALi AC97 Controller
   DEPENDS:=+kmod-ac97
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to