Hi Felix, Sorry, I'm still learning how this project works ... I have been trying to follow the patch submission checklist as best I can.
Perhaps that adivce could be added to the guidelines on https://dev.openwrt.org/wiki/SubmittingPatches page, but I only worked out how to get edit access to other wiki http://wiki.openwrt.org/. Do you know where I can propose changes to the dev wiki? (I was confusing for quite a while when I started, being there is a forum and two wikis and a mailing list...) I think of the patches I have submmited just now, the MTD and the ring size are the only ones directly copied as such --Andrew On 14/05/13 22:32, Felix Fietkau wrote: > On 2013-05-14 2:44 PM, Andrew McDonnell wrote: >> >> This patch adds a kernel target for the D-Link DIR-632-A1. >> >> Note that the CONFIG_MTD_CFI_I2 and BANK changes are duplicated from DD-WRT >> and the D-Link firmware; I think it is because this uses a different flash >> chip (mx25l6405d) from many of the other similar devices. > Please don't port random changes from DD-WRT that serve no real purpose > and aren't understood properly. The MTD related changes in that patch > are bogus and don't affect the SPI based flash chip in this board. > > - Felix > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel