Hi Daniel,

On Mon, Aug 19, 2013 at 01:45:28PM -0700, Daniel Gimpelevich wrote:
> I've also submitted this upstream. Without it, the module causes an oops
> on rt5350. 
> 
> Signed-off-by: Daniel Gimpelevich <dan...@gimpelevich.san-francisco.ca.us>
> ---
>  .../patches-3.10/005-hso-stack-clobber-fix.patch   |   56 
> ++++++++++++++++++++
>  .../patches-3.3/005-hso-stack-clobber-fix.patch    |   56 
> ++++++++++++++++++++
>  .../patches-3.6/005-hso-stack-clobber-fix.patch    |   56 
> ++++++++++++++++++++
>  .../patches-3.8/005-hso-stack-clobber-fix.patch    |   56 
> ++++++++++++++++++++
>  .../patches-3.9/005-hso-stack-clobber-fix.patch    |   56 
> ++++++++++++++++++++
>  5 files changed, 280 insertions(+)
>  create mode 100644 
> target/linux/generic/patches-3.10/005-hso-stack-clobber-fix.patch
>  create mode 100644 
> target/linux/generic/patches-3.3/005-hso-stack-clobber-fix.patch
>  create mode 100644 
> target/linux/generic/patches-3.6/005-hso-stack-clobber-fix.patch
>  create mode 100644 
> target/linux/generic/patches-3.8/005-hso-stack-clobber-fix.patch
>  create mode 100644 
> target/linux/generic/patches-3.9/005-hso-stack-clobber-fix.patch

Please update your patches with better commit message. It should also
contain links to the mailing list and/or patchwork where the patch was
sent (if possible of course).

Also, patches inside generic should have very detailed description. This
is not the case for many patches at the moment but I plan to work on
this in the (near) future.

Take a look at the links bellow for an example:

https://dev.openwrt.org/changeset/37808
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.10/470-mtd_m25p80_add_pm25_flash_support.patch

Luka
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to