* Enrico Mioso <mrkiko...@gmail.com> [28.08.2013 13:33]:
> Update dropbear to it's latest stable version, and delete unneeded patches:
> - IPV6 splitted port notation now supported upstream
> - if a dbclient invalid option is passed, only a warning is emitted
> 
> Signed-off-by: Enrico Mioso <mrkiko...@gmail.com>

i have tested the patch und i'am fine with it.

i suggest adding the attached patch, which is from dropbear/upstream
but not included in the recent release but in HG-repo. it seems that
this is needed for arch X86/32bit. otherwise connecting to an old
client hangs infinitely while parsing /proc/timer_list during
connection:

https://secure.ucc.asn.au/hg/dropbear/rev/5de524aec047

i tested on x86 32+64bit, mips/ar71xx and brcm47xx.

bye, bastian
diff -r 1d1f80fcbcb3 -r 5de524aec047 random.c
--- a/random.c	Mon May 13 21:35:13 2013 +0800
+++ b/random.c	Tue May 28 22:16:57 2013 +0800
@@ -77,7 +77,7 @@
 	while (len == 0 || readcount < len)
 	{
 		int readlen, wantread;
-		unsigned char readbuf[2048];
+		unsigned char readbuf[4096];
 		if (!already_blocked)
 		{
 			int ret;
@@ -208,12 +208,13 @@
 	process_file(&hs, "/proc/loadavg", 0, 0);
 	process_file(&hs, "/proc/sys/kernel/random/entropy_avail", 0, 0);
 
-	/* Mostly network visible but useful in some situations */
-	process_file(&hs, "/proc/net/netstat", 0, 0);
-	process_file(&hs, "/proc/net/dev", 0, 0);
-	process_file(&hs, "/proc/net/tcp", 0, 0);
+	/* Mostly network visible but useful in some situations.
+	 * Limit size to avoid slowdowns on systems with lots of routes */
+	process_file(&hs, "/proc/net/netstat", 4096, 0);
+	process_file(&hs, "/proc/net/dev", 4096, 0);
+	process_file(&hs, "/proc/net/tcp", 4096, 0);
 	/* Also includes interface lo */
-	process_file(&hs, "/proc/net/rt_cache", 0, 0);
+	process_file(&hs, "/proc/net/rt_cache", 4096, 0);
 	process_file(&hs, "/proc/vmstat", 0, 0);
 #endif
 

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to