On 2014-03-21 14:59, Felix Fietkau wrote: > On 2014-03-21 14:09, Oskari Rauta wrote: >> This patch removes dependancy of PPP from chat application as chat >> application can be used for other serial communication as well that is not >> dependant on PPP and therefore one should be able to install chat without >> PPP. There also are no dependencies within chat application for PPP. >> >> Signed-off-by: Oskari Rauta <oskari.rauta at gmail.com> >> --- >> diff --git a/package/network/services/ppp/Makefile >> b/package/network/services/ppp/Makefile >> index d4aab38..9bf9616 100644 >> --- a/package/network/services/ppp/Makefile >> +++ b/package/network/services/ppp/Makefile >> @@ -120,7 +120,6 @@ endef >> define Package/chat >> $(call Package/ppp/Default) >> - DEPENDS:=@(PACKAGE_ppp||PACKAGE_ppp-multilink) >> TITLE:=Establish conversation with a modem >> endef > Does not apply, because the last line with a whitespace character was > stripped. By the way, the email subject also makes it into the commit > msg (as the first line), so it should be correctly formatted and not > include things like "(inline attachment included?)" > > The correct format here would be: > [PATCH] ppp: remove ppp dependency from chat By the way, if you want to make life a lot easier for you when sending patches, I'd suggest that you configure git send-email. That way you won't have to fight your email client for patches anymore ;)
- Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
