-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi OpenWrt crew,
Hi Chris,

On 03/31/2014 10:15 PM, Jonas Gorski wrote:
> On Mon, Mar 31, 2014 at 9:59 PM, Daniel <dan...@makrotopia.org> wrote:
>> fiq broadcast DMA cache maintenance is needed for ARM11MPCore, the 
>> to-be-added 'oxnas' hardware target use that core.
>> 
>> --- .../315-arm_introduce-dma-fiq-irq-broadcast.patch  | 62
>> ++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode
>> 100644
>> target/linux/generic/patches-3.13/315-arm_introduce-dma-fiq-irq-broadcast.patch
>
>> 
> Is there a reason why this is in generic if it is needed only by one
> target?
Simply, because it could go upstream (no dependencies), not hurt anyone and
adds generic piece of the patch found on
https://github.com/kref/linux-oxnas/commit/753546ecb652b63598eb023a7457d21293937b48

> Is this a backport from 3.14? If yes, it should be 0xx, if not then it 
> should be also added to 3.14. If "no", is it submitted upstream?
I don't know if the original author already submitted it.

> Also please read 
> https://dev.openwrt.org/browser/trunk/target/linux/generic/PATCHES, the
> parts regarding upstreamability.
> 
> And lastly: you are missing the Signed-off-by.
I didn't author anything there, just stripped the generic part of the story
from the target-specific one. I don't believe that gives a legitimate reason
according to the guidelines (which I do know)
"The contribution was created in whole or in part by me..." -> not the case 
here.

Chris: did you submit this upstream and/or do you agree to do so now or do you
want me to do it?


Cheers


Daniel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTOc8sAAoJECBgbL4bcbCQ7pkH/2oHLKYsjFUlnk+ghEl4Y3a4
SqWKJjP9kBFbsbWYBKlkZiV3AYbTCnH9QwuPrBGd28rE5G4T+uGDNaxo5CO7tYMT
8A/n2Ks0W00iZKfvMgAA+lz29BdO4A7IVLDdqsql3DQ3VYpJH3YRbWtA1wAGUZsK
1A/OCoO88TmAfLVawXaX0DR8M8cdA6mz6FyR33pKQiibNl7uM8b3fbPyouWV/BNv
1VK9VVN2+TwTaxV11QTVN6WNhzWtjsnqs6Wmmg6WWRvPtTmP5fipi02KuAHcmW0A
tZqF00OieBEgedbd382Mk3bmk0ftE4ENXtnl3Onslu6u96MZfLJOHcp6cZe46Fo=
=/UlA
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to