On 2014-10-06 10:01, Hattink, Tjalling [FINT] wrote: > Hi Felix, > > The first patch I submitted was faulty. I forgot to notify the > mailinglist about this, my apologies. The problem is the $(subst > ",,$(KERNELNAME))" part. For most targets KERNELNAME is defined so the > command is expanded to something like "make bzImage modules". But for > the targets that do not have KERNELNAME defined (for example, the at91 > target) the command is expanded to "make modules". In this case the main > image is not compiled anymore, only the modules. > > I tried to fix this by first calling make with the KERNELNAME only (or > empty, which will build the default kernel image target), and then a > second call to make for only modules. An alternative way to fix this is > to make sure KERNELNAME is defined for every target, but that requires > reworking the target makefiles, and could break 3rd party targets that > do not have KERNELNAME defined. I noticed that yesterday after applying the patch, and I fixed it. First I removed all the stupid adding/removing of quotes, then I added a $(if $(KERNELNAME),$(KERNELNAME),all) before modules.
- Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel