On Wed, Dec 10, 2014 at 9:10 AM, Hans Dedecker <dedec...@gmail.com> wrote: > As a side effect of this patch I noticed multiple default routes (one > default route with source IP set and one default route with source IP > unset) are present in netifd if the dhcp server replies the default > route both in the router option and the staticroutes option. Before > the patch the default routes were considered as identical by netifd as > the route key was the same; but since the source IP is set now for one > of the default routes this is not the case anymore. > Is there any reason why the source IP is not set when the staticroutes > are added in set_classless_routes in the dhcp script ?
I completely failed to consider static (classless) routes when writing this patch. I am not able to test this now, but based on my understanding of the RFC it should be safe to add source here as well. I am not sure if it will work with multiple default routes though, so I guess you just have to test. There is at least no particular reason for why I did not add it :) -Kristian _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel