On 2014-11-12 14:59, Yousong Zhou wrote: > Signed-off-by: Yousong Zhou <yszhou4t...@gmail.com> > --- > json_script.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/json_script.c b/json_script.c > index 0ec7b38..0d51f79 100644 > --- a/json_script.c > +++ b/json_script.c > @@ -338,7 +338,7 @@ static int handle_expr_not(struct json_call *call, struct > blob_attr *expr) > if (!tb[1]) > return -1; > > - return json_process_expr(call, tb[1]); > + return !json_process_expr(call, tb[1]); Simply adding ! is not enough. This needs to check for ret < 0 for proper error handling.
- Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel