On 29 December 2014 at 08:12, Vittorio G (VittGam) <[email protected]> wrote: > On 26 December 2014 at 09:53, Rafał Miłecki <[email protected]> wrote: >> >> On 26 December 2014 at 09:51, Rafał Miłecki <[email protected]> wrote: >>> >>> On 25 December 2014 at 02:28, Vittorio G (VittGam) <[email protected]> >>> wrote: >>>> >>>> Signed-off-by: Vittorio Gambaletta <[email protected]> >>>> >>>> diff --git a/package/base-files/files/lib/functions/leds.sh >>>> b/package/base-files/files/lib/functions/leds.sh >>>> index 4ac8145..d4d4512 100644 >>>> --- a/package/base-files/files/lib/functions/leds.sh >>>> +++ b/package/base-files/files/lib/functions/leds.sh >>>> @@ -60,7 +60,7 @@ status_led_blink_fast() { >>>> } >>>> >>>> status_led_blink_preinit() { >>>> - led_timer $status_led 200 200 >>>> + led_timer $status_led 100 100 >>>> } >>>> >>>> status_led_blink_failsafe() { >>>> @@ -68,5 +68,5 @@ status_led_blink_failsafe() { >>>> } >>>> >>>> status_led_blink_preinit_regular() { >>>> - led_timer $status_led 500 500 >>>> + led_timer $status_led 200 200 >>>> } >>> >>> >>> 1) Why? >>> 2) Explain "as before" >>> 3) I don't think there is enough difference between 100ms and 200ms >> >> >> 4) You don't mention status_led_blink_preinit(), but your patch also >> touches it > > > 1) I think that most OpenWrt users, like me, are accustomed to see a led > pattern of 200ms. I thought it was a bad flash or something else bad when > I've seen that 500ms blinking...
Is there any reason for that? Was 200ms ever used or documented by OpenWrt? > 2) "As before" means that when failsafe is possible, it is indicated by a > new pattern of 100ms. When it is not possible anymore, the > "classic"/previous 200ms pattern is used. "As before" and "new pattern" seem to be in conflict ;) Same question (as above) about the 200ms. What makes it "classic" or "previous"? 500ms looks OK for me, just calm booting, not sure about other people opinion. But I don't like using 50ms / 100ms / 200ms for 3 different states because I find them too close/similar. Also if preinit was always using 200ms (am I wrong? can you prove different interval?) I don't think we should change it to 100ms. -- Rafał _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
