On Sun, Jan 25, 2015 at 08:50:32PM +0100, Imre Kaloz wrote: > Hi, > > On Sun, 25 Jan 2015 18:06:03 +0100, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: > > >>Sure, but please implement UBI on NOR as a generic solution. > > > >What do you mean? It already works quite well (with that patch applied > >and the NOR sub-profile), so I'm not sure I have to implement > >anything, be it generic or not. > > I've meant to make it generic, like the squashfs/ubfs/etc images so other > targets can use it, too.
Well, it uses only prepare_squashfs_image and UbinizeImage works great for that already, the only thing that differ is the set of options given to ubinize, so I'm not really sure how that can be turned into something more generic. > >>>>The A385-RD board has a much smaller SPI-NOR (16MB) though, so we > >>>>could use jffs2 there, but I wasn't seeing much point at creating a > >>>>whole new layout just for a single board. > >>> > >>>I'll switch this one to JFFS2 and the MTDSPLIT framework. Are you > >>>satisfied with the NAND support? Just to know if I can continue to > >>>model the NOR stuff on that. > >> > >>As I've written in the other mail, I'm mostly happy with it, but > >>please make sure you don't hardcode available profiles but parse > >>them. > > > >If we don't plan on supporting building single sub-profiles like > >ar71xx, I'm not even sure that we need to parse anything, we can just > >loop over the sub-profiles list in any case. > > I think supporting that could be handy so users (and people at Marvell) can > just build what they want. Ok. But what/how do you want me to parse these profiles then? Apart from plumbing into the Profile macro itself to add the list of available profiles, and that would be way too intrusive, I don't really get what you expect here. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
