On 21 March 2015 at 06:06, wengbj <fl.serv...@t-firefly.com> wrote: > Signed-off-by: wengbj <fl.serv...@t-firefly.com> > --- > target/linux/ramips/dts/FIREWRT.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/linux/ramips/dts/FIREWRT.dts > b/target/linux/ramips/dts/FIREWRT.dts > index 54f0e55..2b018e6 100644 > --- a/target/linux/ramips/dts/FIREWRT.dts > +++ b/target/linux/ramips/dts/FIREWRT.dts > @@ -103,6 +103,11 @@ > gpios = <&gpio0 18 1>; > linux,code = <0x211>; > }; > + power { > + label = "power"; > + gpios = <&gpio0 23 1>; > + linux,code = <116>; > + };
Could you break this bad habit and use KEY_* instead of magic numbers? Like a KEY_POWER. -- Rafał _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel