On 17 April 2015 at 10:50, Arend van Spriel <ar...@broadcom.com> wrote: > On 04/17/15 09:45, Rafał Miłecki wrote: >> >> Huh, why dropping linux-wireless (and top posting btw)? Please let >> everyone follow the discussion :) >> >> On 15 April 2015 at 21:20, Hante Meuleman<meule...@broadcom.com> wrote: >>> >>> As I wrote to you in a mail and on the openwrt forum, this patch is >>> indeed an attempt to support more complex nvram files. I also wrote, that in >>> order to be able to use it, the nvram contents of the device (r8000) needs >>> to be put a specific file. Now for your concerns, we can perhaps add >>> something which will read the nvram contents directly from an nvram store. >>> But that is irrelevant to this patch. The parsing is still needed, and all >>> we would need to add is something which is reading the nvram contents from >>> some other place >> >> >> So it makes me wonder if we need this patch in its current form. I >> think getting NVRAM directly from the platform is much user friendly. >> It doesn't require user to install some extra tools for dumping NVRAM >> and putting it in a specific file. One extra layer less. >> With that said I think it's hard to review your code for parsing >> NVRAM. We don't know how it's going to be fetched in the first place. > > You already made that point and we agreed to look for a solution.
OK, it wasn't supposed to be rude or anything :) Thanks. >>> though it would have to be put under some kernel config flag as this >>> would not be supported in non-router systems. The contents of the nvram >>> would however still need to be parsed in exactly the same way as the nvram >>> files we read from disk. >> >> >> Again, it's hard to say for me. Are you going to use >> bcm47xx_nvram_getenv? Are you going to use MTD subsystem? Are you >> going to develop different solution? When using e.g. >> bcm47xx_nvram_getenv you won't want all this parsing stuff at all. > > > Please look at the usage scenario here. The brcmfmac driver is not needing a > few key,value pairs. It needs a portion of NVRAM to download to the device. > The patch provides the functionality to do just that. Get the appropriate > portion, strip comments and whitespace, and send it to the device. Using > bcm47xx_nvram_getenv is not a useful api as it would mean we need brcmfmac > to know which key ids to ask for, reassemble it to key=value string and send > it to the fullmac device. > > In bcm47xx_nvram_getenv() it does have the whole nvram content available in > nvram_buf which is filled by nvram_init(). So if something similar is made > available on r8000 (or ARM routers in general) build target all we need is > an api to get the nvram_buf. > > Another option is to add the parsing stuff in that nvram code and have an > api to get the appropriate portion based on pcie domain and bus number as > used in brcmf_fw_get_firmwares_pcie(). However, I would prefer to have this > in the driver and not in arch specific code as there may be other platforms > like our set-top boxes needing this. This is some plan for the future I was lacking from the beginning. It makes things more clear now, thanks. -- Rafał _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
