On 28/09/2015 14:14, Helmut Schaa wrote: > On Mon, Sep 28, 2015 at 12:58 AM, Alexander Couzens <[email protected]> wrote: >> The kernel wdt counting down even when not pinged. >> Shutdown the filehandler to /dev/watchdog with magic cookie >> to prevent this. >> >> Signed-off-by: Alexander Couzens <[email protected]> >> --- >> watchdog.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) >> >> >> I'm not certainly clear, the previous behaviour was a bug or feature. >> If stop=True should really only stop the pinging thread, I really would like >> to shutdown the watchdog gracefully on another way. E.g. with another >> argument >> shutdown. >> > > I've always interpreted the call that it just stops triggering the > watchdog and might > force a hw reset. So IMO it would make sense to add a parameter to specify the > exact action that should be taken. > > Helmut >
indeed the patch is imho partially incorrect. there are 2 ways to close the device. this patch would break existing users of the function _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
