Hi John, On 29 October 2015 at 06:38, John Crispin <blo...@openwrt.org> wrote: > Hi, > > On 29/10/2015 02:26, Andrej Vlasic wrote: >> Add missing icplus phy driver kernel config symbol to mt7620 subtarget. >> This is needed since some mt7620 devices have icplus ip1001 ethernet >> transceiver >> >> Signed-off-by: Andrej Vlasic <andrej.vlas...@gmail.com> > > are you sure this is needed ? older IC+ phys worked with the generic phy > driver. however that might have changed for the gbit version. > > John >
I just checked without icplus driver, and it does work with generic driver. The only thing that I can see that is in ip1001 driver and it's not in generic driver is support for auto power saving mode. > >> --- >> target/linux/ramips/mt7620/config-3.18 | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/target/linux/ramips/mt7620/config-3.18 >> b/target/linux/ramips/mt7620/config-3.18 >> index 0263bba..5dbfaa2 100644 >> --- a/target/linux/ramips/mt7620/config-3.18 >> +++ b/target/linux/ramips/mt7620/config-3.18 >> @@ -11,6 +11,7 @@ CONFIG_ARCH_REQUIRE_GPIOLIB=y >> CONFIG_ARCH_SUSPEND_POSSIBLE=y >> CONFIG_ARCH_WANT_IPC_PARSE_VERSION=y >> CONFIG_AT803X_PHY=y >> +CONFIG_ICPLUS_PHY=y >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y >> CONFIG_CEVT_R4K=y >> CONFIG_CLKDEV_LOOKUP=y >> > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel