Hi, On Sun, Jan 10, 2016 at 04:47:05AM -0500, Daniel Dickinson wrote: > I used git send-email so there shouldn't be any whitepspace mangling > issues, unless patchwork is to blame.
Over at openvpn-devel, we recently discovered that some versions of
MS Exchange mangle whitespace for "mails in transit" - so even when the
user did everything right (git send-email, etc.) Exchange still converted
all tabs to 8x Space, leading to non-applying patches.
Solution: send via freemail provider, using direct SMTP+Auth (which
git send-email can do).
> That leaves receive-side error. It seems likely given the line the
> error is on, that patchwork is pickier than git or the vim bit you sent
> me. That is the 'offending' line is a shell script that happens to have
> 8 spaces instead of tab. Methinks this is not a relevant thing to
> complain about in a shell script; also I wonder whether it would do the
> same with with e.g. Python? I suspect patchwork is applying Makefile
> rules to all patches, which is just wrong.
The problem often is context. If the parts before or after the actual
change get whitespace-modified, git am will not accept it (traditional
patch will, and complain about fuzz needed).
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
