On 2016-01-10 17:07, Álvaro Fernández Rojas wrote: > This add support for IGMP Snooping on atheros switches (disabled by default), > which avoids flooding the network with multicast data. > > Tested on TL-WDR4300: disabling IGMP Snooping results in multicast flooding > on each specific port, enabling it back again prevents each port from > receiving all multicast packets. > > Partially based on: http://patchwork.ozlabs.org/patch/418122/ > > Signed-off-by: Álvaro Fernández Rojas <nolt...@gmail.com> > --- > v2: introduce changes suggested by Linus Lüssing > - switch to disabled by default > - add MLD snooping support > - allow enabling/disabling IGMP v3, join and leave > - add functions for controlling settings on all ports > At least igmp_snooping, igmp_fast_join and igmp_fast_leave must be enabled > in order to get IGMP working. MLD Snooping and IGMP v3 are optional. I'd prefer to expose as few knobs as possible for this. If fast_join and fast_leave are required for IGMP snooping to work, there is no point in making them configurable separately.
Also it's weird to have MLD support and IGMP v3 configurable both globally and per-port. Please derive the per-port config from the global one instead of having separate attributes. Also, you can simplify the callback structure by storing the state of the various parameters in the struct and then just having one function for applying the configured IGMP snooping state. - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
